Re: distributing test tools

2013-03-08 Thread Leif Hedstrom
On Mar 8, 2013, at 2:04 AM, Yunkai Zhang wrote: > I found that there so many code breaking our coding style, such as "tailing > spaces", "beyond 80 characters per line". Trailing spaces is bad, but our coding standard allows long lines. Limiting to 80 characters is lame and outdated IMO. :) --

Re: distributing test tools

2013-03-08 Thread Yunkai Zhang
I found that there so many code breaking our coding style, such as "tailing spaces", "beyond 80 characters per line". I suggest add a tool, like https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl, to help developers self checking before sending/merging patches. On Fri, Mar 8, 20

Re: distributing test tools

2013-03-07 Thread Phil Sorber
On Thu, Mar 7, 2013 at 1:31 PM, James Peach wrote: > Hi all, > > Just a heads-up. I'm planning to integrate the binaries in the tools > directory so they will be built and installed by default. This means jtest, > http_load and tstop. If anyone has any opinions or advice, I'm all ears ... > > The

Re: distributing test tools

2013-03-07 Thread James Peach
On 07/03/2013, at 10:31 AM, James Peach wrote: > Hi all, > > Just a heads-up. I'm planning to integrate the binaries in the tools > directory so they will be built and installed by default. This means jtest, > http_load and tstop. If anyone has any opinions or advice, I'm all ears ... What ab