Re: RFC: convert from NULL tp nullptr

2016-10-17 Thread Bryan Call
It is a good idea. I would like to make sure we land it before a release instead of after, so it would be easier for release manager to backporting fixes. -Bryan > On Oct 16, 2016, at 9:15 AM, James Peach wrote: > > Hi all, > > I’ve posted a RFC pull request >

Re: RFC: convert from NULL tp nullptr

2016-10-17 Thread Chao Xu
+1 2016-10-17 1:51 GMT+08:00 James Peach : > > > On Oct 16, 2016, at 9:18 AM, Leif Hedstrom wrote: > > > > I'll try to review next week, but I'm +1 on the concept. I assume we > have places were we use 0 but really should use nullptr? > > The only weird think I found is that we used NULL for an

Re: RFC: convert from NULL tp nullptr

2016-10-16 Thread James Peach
> On Oct 16, 2016, at 9:18 AM, Leif Hedstrom wrote: > > I'll try to review next week, but I'm +1 on the concept. I assume we have > places were we use 0 but really should use nullptr? The only weird think I found is that we used NULL for an invalid pthread_t (which is an integral type in glib

Re: RFC: convert from NULL tp nullptr

2016-10-16 Thread Leif Hedstrom
I'll try to review next week, but I'm +1 on the concept. I assume we have places were we use 0 but really should use nullptr? -- Leif > On Oct 16, 2016, at 9:15 AM, James Peach wrote: > > Hi all, > > I’ve posted a RFC pull request > that c