Re: Help with collapsed_connection plugin.

2017-06-22 Thread James Peach
> On Jun 23, 2017, at 12:44 AM, John Rushford wrote: > > Leif, > > The mutex is ref counted but the i look at the code for TSContDestroy, I > see that the pointer to the mutex is only set to NULL, > INKContInternal::destroy(). I think that the plugins should call > TSMutexDestroy() also. Is

Re: Help with collapsed_connection plugin.

2017-06-22 Thread John Rushford
Leif, The mutex is ref counted but the i look at the code for TSContDestroy, I see that the pointer to the mutex is only set to NULL, INKContInternal::destroy(). I think that the plugins should call TSMutexDestroy() also. Is that correct? On Thu, Jun 22, 2017 at 6:59 AM, Leif Hedstrom wrote:

Re: Help with collapsed_connection plugin.

2017-06-22 Thread Leif Hedstrom
Yes, this is the correct fix. In earlier versions, the core would create the mutex for you if it needed one, but this had some pretty expensive overhead. So now we just assert instead, so people can fix their plugins (and our plugins apparently). Fwiw, the mutex is needed when the continuation

Re: Help with collapsed_connection plugin.

2017-06-21 Thread John Rushford
Peter, I've found this with a couple of other plugins and fixed them by making exactly the change you you're asking about. In testing i have not run into any issues with the plugins i have changed. John > On Jun 21, 2017, at 4:22 PM, Chou, Peter wrote: > > Hi, > > I am taking a look at t