Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-05-04 Thread Leif Hedstrom
> On May 4, 2023, at 2:50 PM, Bryan Call wrote: > > It is an experimental feature that isn’t used to my knowledge. I am ok with > removing it for 10.x. > > If it was a supported feature then we should do the deprecation in one major > version and then remove it in the next major version pr

Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-05-04 Thread Bryan Call
It is an experimental feature that isn’t used to my knowledge. I am ok with removing it for 10.x. If it was a supported feature then we should do the deprecation in one major version and then remove it in the next major version process. -Bryan > On Apr 24, 2023, at 9:28 AM, Chris McFarlen wr

Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-04-24 Thread Chris McFarlen
Thanks to everyone for the feedback. We have decided to deprecate the NATIVE AIO (libaio) implementation and will remove it after 10.x. Chris Sent with Proton Mail secure email. --- Original Message --- On Wednesday, April 19th, 2023 at 11:17 PM, Zhao Yongming wrote: > missed this

Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-04-19 Thread Zhao Yongming
missed this thread, I think I need to make it clear that linux native AIO in the stage of very beta after our Weijin's work, and we are sure that it is not in good performance, and we don't use it anywhere. I believe we just do it in suggest of Leif or someone else so we can compare what is our dir

RE: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-04-04 Thread Alan Carroll
I agree with deprecating Linux native AIO. I have heard of many problems with it and not once any successful use. I don't think it's the ATS implementation, I think the kernel support has never been all there. And now with io_uring, I doubt it will ever be fixed, rather native AIO will be replac

Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-04-04 Thread Chris McFarlen
> > On Apr 3, 2023, at 11:38, Chris McFarlen ch...@mcfarlen.us wrote: > > > > I would like to remove this disk IO mode from ATS. If nobody is using it, > > then I'd like to delete it for the 10.x release. If that isn't possible, I > > think it should be deprecated in favor of io_uring and remo

Re: Feedback on removing AIO_MODE_NATIVE from iocore/aio

2023-04-03 Thread Leif Hedstrom
> On Apr 3, 2023, at 11:38, Chris McFarlen wrote: > > I would like to remove this disk IO mode from ATS. If nobody is using it, > then I'd like to delete it for the 10.x release. If that isn't possible, I > think it should be deprecated in favor of io_uring and removed in a future > versio