Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Brian Neradt
Considering this input: - I changed the TSHttpTxnClientStreamIdGet to return a uint64_t. - I removed 0_9 from the protocol type list and added HTTP_PROTOCOL_TYPE_HTTP_UNSPECIFIED. - I renamed TSHttpProtocolType to TSHttpPriorityType. The API functions now look like: tsapi TSReturnCod

Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Brian Neradt
Correct, a regular C struct. On Wed, Sep 2, 2020 at 11:28 AM Leif Hedstrom wrote: > > > > On Sep 1, 2020, at 3:11 PM, Alan Carroll > wrote: > > > > Sorry for chiming in late - > > > > Note this is extremely similar to IP addresses and I recommend we use the > > same solution. That is, there is

Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-09-02 Thread Leif Hedstrom
> On Sep 1, 2020, at 3:11 PM, Alan Carroll > wrote: > > Sorry for chiming in late - > > Note this is extremely similar to IP addresses and I recommend we use the > same solution. That is, there is a class HttpPriority which has just a > type/style/family value and possibly a length. This is

Re: [E] TS API Review: New HTTP/2 stream id and priority getters

2020-08-31 Thread Walt Karas
Would traffic replay use this information? More generally, what I'm wondering is, how does traffic dump coordinate with TS's logging capability? I think typically, the TS API provides these sorts of handles to plugins so they can change the processing of the transaction/session/etc. We could als