Re: [E] Re: [API] for accessing server session transaction count

2020-12-14 Thread Damian Meden
Hello guys, this new API is now implemented -> https://github.com/apache/trafficserver/pull/7387 . Any feedback will be appreciated. The PR also includes a new header rewrite condition( SSN-TXN-COUNT) that consumes this new API. Regards, Damian. On Wed, Nov 18, 2020 at 10:59 PM Sudheer Vinukonda

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Sudheer Vinukonda
Yeah, you are right. I got mixed up because we *talked* about supporting generic log tags via header-rewrite in the past.  Looks like that support was never added. On Wednesday, November 18, 2020, 02:51:33 PM PST, Shu Kit Chan wrote: I don't think this will work. Prior to 9.x , header

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
I don't think this will work. Prior to 9.x , header rewrite plugin supports a fixed set of string substitutions. e.g. %, % But it is never for generic log tag. And i think this style of string substitutions are deprecated after 9.x In fact, I don't think there are APIs for plugin to get these log

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Susan Hinrichs
In this scenario they would set "Connection: close" in the request header. I am assuming they don't have the control over the origin to make this change there. Or it is always easier to hassle the proxy folks to get these things done :-) On Wed, Nov 18, 2020 at 2:39 PM Shu Kit Chan wrote: > Ac

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Susan Hinrichs
Hmm, I wasn't aware you could access log tags from header-rewrite. On Wed, Nov 18, 2020 at 3:28 PM Sudheer Vinukonda wrote: > New API sounds reasonable. > For the use case in question though, it may be possible to use > header-rewrite rules to achieve this using the log tag 'sstc' > Not 100% su

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Susan Hinrichs
Correct. Cut-n-paste problems. On Wed, Nov 18, 2020 at 2:29 PM Shu Kit Chan wrote: > I think you mean the existing one is TSHttpSsnTransactionCount . Right ? > > > On Wed, Nov 18, 2020 at 12:15 PM Susan Hinrichs > wrote: > > > > I propose int TSHttpTxnServerSsnTransactionCount(TSHttpTxn txn)

Re: [API] for accessing server session transaction count

2020-11-18 Thread Sudheer Vinukonda
New API sounds reasonable.  For the use case in question though, it may be possible to use header-rewrite rules to achieve this using the log tag 'sstc' Not 100% sure, but something like this might (I haven't tested it) work? cond %{SEND_RESPONSE_HDR_HOOK} cond % =10set-header Connection close

Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
Actually I was thinking about this question a bit. 2 points to make. 1) I am Ok with the naming convention 2) So the origin wants to be the one to set "Connection: close" in the response. Wouldn't the origin also has that piece of information (transaction count) to make that decision? May be thei

Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
I think you mean the existing one is TSHttpSsnTransactionCount . Right ? On Wed, Nov 18, 2020 at 12:15 PM Susan Hinrichs wrote: > > I propose int TSHttpTxnServerSsnTransactionCount(TSHttpTxn txn) as an > addition to the InkAPI. It returns the number of transactions that have > been performed o