Re: [E] New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-07 Thread Jeff Elsloo
Hi all, Based on a brief conversion on Slack with amc, I've added the length argument. Update commit: https://github.com/apache/trafficserver/pull/7783/commits/b44c9d932f3c4d9fdbdb037d7286d859e260bfe1 Please let me know if there is any other feedback on this API. -- Thanks, Jeff On Thu, May 6,

Re: [E] New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-06 Thread Jeff Elsloo
I just pushed a commit that incorporates this feedback and updated the dependent PR that enhances the xdebug plugin to reflect the change. The diff is as follows: – tsapi TSReturnCode TSHttpTxnCacheDiskPathGet(TSHttpTxn txnp, const char **path); + tsapi const char *TSHttpTxnCacheDiskPathGet(TSHttp

Re: [E] New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-05 Thread Alan Carroll
Going forward we want to be view oriented, and also to be consistent with other API, the signature should be arranged to return a view. E.g. const char * TSHttpTxnCacheDiskPathGet(TSHttpTxn txn, int * length); This is modeled on API calls such as TSHttpHdrHostGet, TSHttpTxnPluginTagGet, and the f

New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-04 Thread Jeff Elsloo
Hi all, I'd like to propose the introduction of a new TS API, TSHttpTxnCacheDiskPathGet. The function signature is as follows: tsapi TSReturnCode TSHttpTxnCacheDiskPathGet(TSHttpTxn txnp, const char **path); The intent of this API is to expose the underlying disk used to service a request, regar