Re: [E] Modified and New TS APIs Proposal

2021-07-29 Thread Jeff Elsloo
I just pushed a commit that implements option 2 above because I felt that it was a more straightforward approach that can be easily documented (and is). The alternate approach of `memcpy`ing a static instance, while simple on the surface, seems a little too in the weeds for an API caller that may n

Re: [E] Modified and New TS APIs Proposal

2021-07-29 Thread Alan Carroll
> > Yes, we don't want to mess around with the actual indexing in this PR. > A couple of thoughts - 1. We could have a static instance of the options which could be `memcpy` into the struct to initialize it to default values. 2. It's kind of ugly, but we could have a function to initialize an op

Re: [E] Modified and New TS APIs Proposal

2021-07-28 Thread Jeff Elsloo
I pushed a commit to address items one and three, but the issue with item two is that the range of possible values is bound by an enum that maps to `#defines` in core, both of which are zero indexed (0-14). The item at index zero is the 128 byte buffer size, so if someone in the future uses this st

Re: [E] Modified and New TS APIs Proposal

2021-07-28 Thread Alan Carroll
Yes, that seems in the right direction. A few points: 1. If the struct isn't opaque, then it should be passed by pointer, not by value. 2. There fields must be optional, e.g. I shouldn't be forced to pick some value for the buffering. I'm not sure of the best way to do this - a bit mask? An "inval

Re: [E] Modified and New TS APIs Proposal

2021-07-27 Thread Jeff Elsloo
Hi Alan, I modified the function I introduced to take an options struct as its single argument to reduce the clutter. I added the fields necessary to support my work in PR #8088 and will update #8089 if the changes in the former are accepted. I did not add a field for transparency as you mentioned

Re: [E] Modified and New TS APIs Proposal

2021-07-26 Thread Alan Carroll
There is already a problem where the set of "connect" methods and the options grow without bounds. This first came up with transparency (outbound transparent) and now we have it with IOBuffer control. What I'd like is to create a new connect function that takes an option structure. This would conta

Modified and New TS APIs Proposal

2021-07-26 Thread Jeff Elsloo
Hi all, I'd like to introduce a change to an existing API that leads to a new function signature and add two new related convenience functions that enable plugins. This change enables control of buffer sizes and watermarks used with IOBuffers between the plugin and the core, which is implemented t