Just out of curiosity is the only way to close a github pull request still
to just make a phantom commit?
Brian
On Wed, Dec 2, 2015 at 4:41 PM, Luca Rea wrote:
> Hi,
> about... "To answer Bcall’s email, yes, Github comments ends up on the
> Jira, but not the other way around. So people reading
Hi,
about... "To answer Bcall’s email, yes, Github comments ends up on the Jira,
but not the other way around. So people reading and commenting there see the
entire thread, whereas people only reading the Github PR only sees “half” the
thread." ... perhaps you can try to enable email notificatio
> On Dec 1, 2015, at 4:28 PM, Leif Hedstrom wrote:
>
> One more thing to consider:
>
> How do we coordinate reviews such that we don't do major duplication? It's
> good to have more tha one reviewer (on complicated), but we simple don't have
> the resources sub that every PR gets a large numb
One more thing to consider:
How do we coordinate reviews such that we don't do major duplication? It's good
to have more tha one reviewer (on complicated), but we simple don't have the
resources sub that every PR gets a large number of reviewers.
At a previous place I've been, each PR was assig
> On Dec 1, 2015, at 9:28 AM, James Peach wrote:
>
>
>> On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
>>
>> Now that we agreed to use Github as a patch / review board, the question is:
>> Where do we post comments? On the Jira, or the Github pull request? My
>> preference is constantly
> On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
>
> Now that we agreed to use Github as a patch / review board, the question is:
> Where do we post comments? On the Jira, or the Github pull request? My
> preference is constantly using Jira, for two reasons
>
> 1) Our automated release no
Just a constructive comment but I perosonslly am sort of sick of getting 3
emails for every GitHub comment :/ anything we can do about that regardless?
Brian
On Tuesday, December 1, 2015, Sudheer Vinukonda
wrote:
> It seems like there are pros and cons in both approaches -
> While having the di
It seems like there are pros and cons in both approaches -
While having the discussions on the Jira ticket allows for consistency and easy
to locate them, having comments (especially, code-level comments) on GitHub
allows for highlighting specific portions of the code.
Internally, we make the Gi
Github comments should show up in the Jira if they are property linked to
the ticket. I prefer the discussions in the Jira Ticket.
-Bryan
On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
Now that we agreed to use Github as a patch / review board, the question
is: Where do we post comments? O
> On Nov 30, 2015, at 1:55 PM, Leif Hedstrom wrote:
>
> Now that we agreed to use Github as a patch / review board, the question is:
> Where do we post comments? On the Jira, or the Github pull request? My
> preference is constantly using Jira, for two reasons
>
> 1) Our automated release not
Now that we agreed to use Github as a patch / review board, the question is:
Where do we post comments? On the Jira, or the Github pull request? My
preference is constantly using Jira, for two reasons
1) Our automated release notes refer to the Jira, it’d be a lot easier to track
discussions in
11 matches
Mail list logo
