Re: Consolidate string functions

2011-09-22 Thread Igor Galić
With r1174513 I've cleaned out the last bit of sensibly cleanable code. -- Three things are left: * ink_strncpy()/ink_strncat() I'm considering to change the function definitions so they will kindly suggest (rad as: #error) to use ink_strlcpy/ink_strlcat() * lib/ts/mkdfa.c lib/ts/ink_strin

Re: Consolidate string functions

2011-09-20 Thread Leif Hedstrom
On 09/20/2011 10:22 AM, Leif Hedstrom wrote: On 09/20/2011 05:28 AM, Igor Galić wrote: Right now the last thing left is iocore/ And a second pass to see if I didn't leave anything out. I have halted the progress however, because Leif reported segfaults with no traces with current trunk as forw

Re: Consolidate string functions

2011-09-20 Thread Leif Hedstrom
On 09/20/2011 05:28 AM, Igor Galić wrote: Right now the last thing left is iocore/ And a second pass to see if I didn't leave anything out. I have halted the progress however, because Leif reported segfaults with no traces with current trunk as forward proxy. I've been running the server compil

Re: Consolidate string functions

2011-09-20 Thread Igor Galić
- Original Message - > > > - Original Message - > > Hi folks, > > > > I've been thinking it would be a good idea to consolidate > > calls to > > strcpy() strncpy() ink_strncpy() ink_strlcpy() > > strcat() strncat() ink_strncat() ink_strlcat() > > > > Right now we have all of those

Re: Consolidate string functions

2011-09-14 Thread Igor Galić
- Original Message - > Hi folks, > > I've been thinking it would be a good idea to consolidate > calls to > strcpy() strncpy() ink_strncpy() ink_strlcpy() > strcat() strncat() ink_strncat() ink_strlcat() > > Right now we have all of those floating around: [snip] > > I think it would be a

Consolidate string functions

2011-09-13 Thread Igor Galić
Hi folks, I've been thinking it would be a good idea to consolidate calls to strcpy() strncpy() ink_strncpy() ink_strlcpy() strcat() strncat() ink_strncat() ink_strlcat() Right now we have all of those floating around: igalic@tynix ~/src/ats % ack -lw strcpy |wc -l 43 igalic@tynix ~/src/ats % ac