Re: CPP API change - TXN_CLOSE event handling in TransactionPlugin

2020-05-18 Thread Sudheer Vinukonda
Yeah, We’ve plugins that are in mixed mode and add txn-close hook through C API. If the plugin is just using CPP API, then yes you are right - it’d not crash but leak. > On May 18, 2020, at 6:15 PM, Walt Karas > wrote: > > Hmm I think if you forgot to call 'Transaction::addPlugin()' you w

Re: CPP API change - TXN_CLOSE event handling in TransactionPlugin

2020-05-18 Thread Walt Karas
Hmm I think if you forgot to call 'Transaction::addPlugin()' you would just leak the plugin object, I don't think it would cause the crash you saw. On Mon, May 18, 2020 at 6:38 PM Sudheer Vinukonda wrote: > We recently ran into a core dump issue due to one of our > TransactionPlugin's continuati

CPP API change - TXN_CLOSE event handling in TransactionPlugin

2020-05-18 Thread Sudheer Vinukonda
We recently ran into a core dump issue due to one of our TransactionPlugin's continuations being called back with TXN_CLOSE event. The current CPPAPI's TransactionPlugin does not expect a call back on TXN_CLOSE, and asserts on it. This is because the expectation seems to be that all the continu