Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-28 Thread James Peach
> On Apr 28, 2016, at 3:16 PM, David Calavera wrote: > > Hi everyone! > > Is there anything else I can do to move this forward? Keep hassling me! I’ll try to review in the next few days > > Cheers, > David > > On Mon, Apr 25, 2016 at 9:22 AM, David Calavera > wrote: > >> I've renamed the

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-28 Thread David Calavera
Hi everyone! Is there anything else I can do to move this forward? Cheers, David On Mon, Apr 25, 2016 at 9:22 AM, David Calavera wrote: > I've renamed the function as part of my pull request. You can see the > change in this commit: > > > https://github.com/apache/trafficserver/pull/594/commit

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-25 Thread David Calavera
I've renamed the function as part of my pull request. You can see the change in this commit: https://github.com/apache/trafficserver/pull/594/commits/4fc12c4b2d9bf7ab11b84006cf1be6657868632a Cheers, David On Sun, Apr 24, 2016 at 3:15 PM, David Calavera wrote: > The name change makes sense to m

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-24 Thread David Calavera
The name change makes sense to me. I'll make the change everywhere in my PR tomorrow if everyone agrees with it. To be clear: - Method to create SSL server context: `TSSslServerContextCreate` - Method to destroy any kind of SSL context: `TSSslContextDestroy` On Sun, Apr 24, 2016 at 2:57 PM, James

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-24 Thread James Peach
This looks pretty reasonable to me. One concern I have is that this API creates SSL server contexts, so we ought to distinguish that in the API name. I propose that TSSslContextCreate() be named TSSslServerContextCreate(), and that we define TSSslContextDestroy() will be able to destroy both ser

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-21 Thread Mathias Biilmann
*API Review of adding TSSslContextCreate and TSSslContextDestroy* Hi All, Here's the API review request for the pull request: It adds two new API functions for creating and destroying SSL contexts. Traffic server exposes hooks that plugins can use to load certificates via other mechanisms than

Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-21 Thread David Calavera
Originally proposed in https://github.com/apache/trafficserver/pull/402. It would be convenient to have those two methods in the API to properly create SSL contexts setting the right configuration from records.config. I opened a ticket to track the issue: https://issues.apache.org/jira/browse/TS-