Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-04-01 Thread Leif Hedstrom
> On Mar 30, 2018, at 3:35 PM, Persia Aziz wrote: > > After debugging, I found that TSSslServerContextCreate does not configure the > ssl context with the ocsp data. So I had to make another API, for the OCSP to > work for contexts created by plugin. I will make a PR > > Following is the new

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-30 Thread Persia Aziz
After debugging, I found that TSSslServerContextCreate does not configure the ssl context with the ocsp data. So I had to make another API, for the OCSP to work for contexts created by plugin. I will make a PR Following is the newly proposed API. I need to test this more. ```tsapi TSReturnCod

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-28 Thread Leif Hedstrom
> On Mar 27, 2018, at 9:52 PM, Persia Aziz wrote: > > > @Leif, > > Yes, this is for certificated loaded via plugin. I don't know of any such API > to hand a new context to ATS. Again, looking at the code, the ocsp is enabled > on a context only at the initialization phase. So any context cr

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Persia Aziz
@Leif, Yes, this is for certificated loaded via plugin. I don't know of any such API to hand a new context to ATS. Again, looking at the code, the ocsp is enabled on a context only at the initialization phase. So any context created externally in a plugin does not get configured with the global

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Leif Hedstrom
> On Mar 27, 2018, at 4:36 PM, Alan Carroll > wrote: > > Persia should correct me if I'm wrong, but my understanding is the default > is no handling. The ATS core provides a default handler for OCSP and the > point of this call is to set this context to use the ATS core default OCSP > handler.

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Alan Carroll
Persia should correct me if I'm wrong, but my understanding is the default is no handling. The ATS core provides a default handler for OCSP and the point of this call is to set this context to use the ATS core default OCSP handler. That is how this makes OCSP easier for plugins - rather than writin

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread James Peach
> On Mar 27, 2018, at 1:52 PM, Alan Carroll > wrote: > > Chatting with Persia privately, I recommend changing the name to something > like `TSSslOCSPDefaultHandlingEnable`, which is what it really does > (enable, for that context, the default / core OCSP handling). I'm confused ... isn't the

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Alan Carroll
Chatting with Persia privately, I recommend changing the name to something like `TSSslOCSPDefaultHandlingEnable`, which is what it really does (enable, for that context, the default / core OCSP handling). On Tue, Mar 27, 2018 at 3:23 PM, Persia Aziz wrote: > > @Kit, > Sure. I will provide an exa

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Persia Aziz
@Kit, Sure. I will provide an example plugin. Syeda Persia Aziz Software DeveloperYahoo! Inc.Champaign, Illinois On Tuesday, March 27, 2018, 3:08:31 PM CDT, Shu Kit Chan wrote: And it would be of great help if we can have a example plugin to illustrate hot this can be used. Thanks.

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Shu Kit Chan
And it would be of great help if we can have a example plugin to illustrate hot this can be used. Thanks. Kit On Tue, Mar 27, 2018 at 1:06 PM, Alan Carroll wrote: > I made some comments on the PR. I would recommend at a minimum having a > reference / link over to where the OCSP callback is desc

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Alan Carroll
I made some comments on the PR. I would recommend at a minimum having a reference / link over to where the OCSP callback is described. On Tue, Mar 27, 2018 at 3:04 PM, Persia Aziz wrote: > This API will be used for contexts created in the plugin. Since we already > have the OCSP query,response a

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Persia Aziz
This API will be used for contexts created in the plugin. Since we already have the OCSP query,response and caching mechanism are already in ATS, the developer can choose to use this callback for OCSP stapling. Otherwise the whole OCSP part has to rewritten in the plugin. We have a use case wher

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread James Peach
> On Mar 27, 2018, at 12:45 PM, Persia Aziz > wrote: > > TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx) > TSSslOCSPCallbackSet sets the OCSP callback described in ATS What does "sets the OCSP callback described in ATS" mean? If I'm writing a plugin why would I call this API? > to the S

API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Persia Aziz
TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx) TSSslOCSPCallbackSet sets the OCSP callback described in ATS to the SSL context passed as an argument. This API is useful for contexts created externally via plugin PR: https://github.com/apache/trafficserver/pull/3353/files Syeda Persia Aziz S