Re: API change in 8.x

2019-01-10 Thread Bryan Call
I am not going to merge it to the Apache master branch. People should update their plugins. It is more for me testing 8.0.x with 7.1.x plugins and for groups that want to tray out 8.0.x and are slow to update their plugins. -Bryan > On Jan 10, 2019, at 4:37 PM, Pushkar Pradhan > wrote: >

Re: API change in 8.x

2019-01-10 Thread Pushkar Pradhan
Please merge it into the master ASAP, it will help me :-) On Thu, Jan 10, 2019 at 3:55 PM Bryan Call wrote: > I am doing this already for our internal release and build for ATS 8.0.1. > I don’t know if this helps or not: > > > https://github.com/bryancall/trafficserver/commit/d4d4bcd33cf60e5d936

Re: API change in 8.x

2019-01-10 Thread Bryan Call
I am doing this already for our internal release and build for ATS 8.0.1. I don’t know if this helps or not: https://github.com/bryancall/trafficserver/commit/d4d4bcd33cf60e5d936107561de5d31389c783dc -Bryan > On Jan 4, 2019, at 5:55 PM, Pushkar Pradhan wrote: > > It seems the API TSHttpTxn

Re: API change in 8.x

2019-01-07 Thread Aaron Canary
In similar situations, we have made a compatibility layer which can be dropped when support for 7 is dropped. Something like... PluginAts7Compatibility.h #ifdef TS_VERSION_MAJOR <= 7 int TSHttpTxnStatusSet(...) { return TSHttpTxnSetHttpRetStatus(...); } #endif Then your plugin can use TSHttpTx

RE: API change in 8.x

2019-01-04 Thread Pushkar Pradhan
It seems the API TSHttpTxnSetHttpRetStatus in 7.x was changed to TSHttpTxnStatusSet in 8.x. The underlying code seems to be the same, only the name has changed. I am writing a plugin that calls this function and that I want to work in both 7.x and 8.x codelines. I can wrap the names in a #iifdef l