Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-21 Thread Bryan Call
+1 -Bryan > On Aug 6, 2018, at 2:14 PM, Leif Hedstrom wrote: > > We have this API: > > void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus > http_retstatus); > > > Which on its own is a little strange, but looking at code, and talking to > Alan, I believe this was added whe

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-07 Thread Steven R. Feltner
+1 for the rename of the existing call and the addition of two new APIs On 8/6/18, 2:53 PM, "Derek Dagit" wrote: +1 for the rename +1 for adding the two new functions On Mon, Aug 6, 2018 at 4:41 PM, Alan Carroll < solidwallofc...@oath.com.invalid> wrote: > +1 >

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-07 Thread Chris Lemmons
+1 on both points. On Mon, Aug 6, 2018 at 3:53 PM Derek Dagit wrote: > > +1 for the rename > +1 for adding the two new functions > > On Mon, Aug 6, 2018 at 4:41 PM, Alan Carroll < > solidwallofc...@oath.com.invalid> wrote: > > > +1 > > > > On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote: > > >

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Derek Dagit
+1 for the rename +1 for adding the two new functions On Mon, Aug 6, 2018 at 4:41 PM, Alan Carroll < solidwallofc...@oath.com.invalid> wrote: > +1 > > On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote: > > > > > > > > On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > > > > > We have this AP

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Alan Carroll
+1 On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote: > > > > On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > > > We have this API: > > > > void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus > http_retstatus); > > > > > > Which on its own is a little strange, but looking at

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Leif Hedstrom
> On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > We have this API: > > void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus > http_retstatus); > > > Which on its own is a little strange, but looking at code, and talking to > Alan, I believe this was added when we added

[PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Leif Hedstrom
We have this API: void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus http_retstatus); Which on its own is a little strange, but looking at code, and talking to Alan, I believe this was added when we added remap plugins long ago, to allow such plugins to modify status codes wi