[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r68782930 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -443,19 +430,28 @@ NetAccept::acceptFastEvent(int event, void *ep) goto Lerror; }

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r68778797 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -443,19 +430,28 @@ NetAccept::acceptFastEvent(int event, void *ep) goto Lerror; }

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r68736872 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -281,29 +280,28 @@ NetAccept::do_blocking_accept(EThread *t) return -1; } +

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r68736720 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -281,29 +280,28 @@ NetAccept::do_blocking_accept(EThread *t) return -1; } +

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r68736528 --- Diff: iocore/net/UnixNetAccept.cc --- @@ -117,11 +117,10 @@ net_accept(NetAccept *na, void *ep, bool blockable) vc->id = net_next_connection_

[GitHub] trafficserver pull request #753: Proposal: NetVC Context

2016-06-28 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/753 Proposal: NetVC Context Goal 1st: In the NetVConnection, we have get_local_addr() and get_remote_addr() method. Also have members local_addr, remote_addr and netvc->con.addr. T