Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/366#discussion_r46964787
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
count = res;
goto
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/366#issuecomment-162803942
Answersï¼
1. to implement an one shot accept (like a ftp pasv mode)
2. accept_fn = net_accept, accept_fn is called from NetAccept
3. the alloc_cache poin
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/366#issuecomment-162560602
A few questions -
1. Why is it the destruction of a `NetAccept` a concern - I thought that
only happened during process shutdown. Is there a case
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/366#discussion_r46833574
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
count = res;
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/366
remove alloc_cache from NetAccept
remove alloc_cache from NetAccept & net_accept() to avoid mem leak on
~NetAccept().
add a condition check for vc==NULL follow allocate_vc().
You can merge
