[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/565#issuecomment-209106620 Do you mean ``boost::intrusive_ptr``? That doesn't have any implicit conversions. If we keel OK about keeping the implicit conversion, then most of this di

[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/565#issuecomment-209056115 I'm not sure we need to prevent the implicit conversion to a pointer. What's important is the inability to touch the member variable in `Ptr` that holds t

[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/565 WIP: Make Ptr pointer value private. Make the actual pointer value of Ptr private so that code reaching in to do unsafe direct manipulate has to do it explicitly. Also remove the implic