[GitHub] trafficserver pull request: Ts 3559

2015-12-16 Thread repodude
Github user repodude closed the pull request at: https://github.com/apache/trafficserver/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver pull request: Ts 3559

2015-12-16 Thread repodude
Github user repodude commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-165233715 Closing out, as re-base made many changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: Ts 3559

2015-11-23 Thread repodude
Github user repodude commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-159095402 Yeah, bummer we weren't able to sync up at ATS summit as I think it might be helpful to clarify some of this application's requirements and/or divulging the run-

[GitHub] trafficserver pull request: Ts 3559

2015-10-13 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-147932185 Sorry for dropping the ball on this one @repodude. If you are coming to the ATS summit, I'd like to sit with you and get this merged. There's a few style changes I

[GitHub] trafficserver pull request: Ts 3559

2015-07-07 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-119234117 Two comments. One is a minor style comment about the functions you added to SSLInternal.c. Ideally the API for the functions in there should be the same as the

[GitHub] trafficserver pull request: Ts 3559

2015-06-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-114935138 I made couple of specific comments on ae455eb. Some more general comments on 1d38e70 needs license headers, header guards should use the existing conv

[GitHub] trafficserver pull request: Ts 3559

2015-06-24 Thread repodude
Github user repodude commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-114926338 Session re-use with TLS session tickets requires TLS-extensions which comes into being at TLSv1.0+. As this must be turned on at the client hello,the connect TL