[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread myraid
Github user myraid commented on the pull request: https://github.com/apache/trafficserver/pull/494#issuecomment-187401027 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/494#issuecomment-187394404 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/494#issuecomment-187374466 I think this change is good as the configure.ac has the enable-cppapi check. so, configure won't create a makefile unless both options are used. I tested the

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/494#issuecomment-187297552 Yup, just as James said. enable-cppapi check is needed as well. Also thanks for the fix. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/494#issuecomment-187291464 I think you need to go further here. The C++ API is an optional component, so we also need to check that it is being built. --- If your project is set up for it,

[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...

2016-02-22 Thread jrushf1239k
GitHub user jrushf1239k opened a pull request: https://github.com/apache/trafficserver/pull/494 TS4095: fix the plugins/experimental/Makefile.am for webp_transform plugin. Could not build the master branch this morning as there were build errors with the webp_transform plugin.