[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-25 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221594976 Sounds good. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-25 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221594161 Unfortunately `event_` is actually used in `Transaction::initCachedRequest` to do handle initialization differently for `TS_EVENT_HTTP_TXN_CLOSE`. I don't

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-24 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221442464 Fwiw I think it might make sense to fully remove event_, nothing really needs it. It just helps when debugging if you couldn't get a handle to a request/response ob

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-24 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/663 TS-4481: CPP API - clear handles and reload on demand. The changes are * The handles are cleared, not re-initialized, per hook. * Handles are loaded from the transaction o