[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-222003637 Merged up with commit 456ade9ab35787d39d3414149a0ee04f44008268 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64788248 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio = this-

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64785961 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio = this

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221936130 Cool. Can you mark the Jira with back port to 6.1.2 as well as 6.2.0 please? I'll try to spend some time today and tomorrow to see what we should get into a potenti

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221935663 I went through all the changes with Susan and I will +1 these changes. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221935540 Based on my research it would be an issue for 6.0 and 6.1 as well. TS-3727 change was marked fixed for 6.0. --- If your project is set up for it, you can rep

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64783870 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221927293 @shinrich The Jira vs this PR has slightly different implications :). Is this a 6.0 issue (i.e. would 6.1.x be affected by this) or is it only in 6.2.x ? I'm contem