[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-31 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-222639026 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread jsime
Github user jsime commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-221890278 Thanks for the catches. Fixed that 'i' typo and I switched the full URL in the comment at the top of records.config.default.in over to the shortened version. The li

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-221816974 Some URLs are shorten. They should be unified? e.g. https://docs.trafficserver.apache.org/records.config#thread-variables https://docs.trafficserve

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/666#discussion_r64710906 --- Diff: proxy/config/records.config.default.in --- @@ -15,12 +15,11 @@ CONFIG proxy.config.ssl.number.threads INT -1 CONFIG proxy.config.accept_th

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-25 Thread jsime
GitHub user jsime opened a pull request: https://github.com/apache/trafficserver/pull/666 TS-4377: update documentation links in default configuration files - Updates existing links in default configuration files to point to current Administrator's Guide documentation URLs. - Ad