[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-26 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214584746 Summary is added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214583503 When I send HTTP/2 request to ATS (built with debug option), I always see this assertion is triggered. It looks like `make check` and Regression Tests could

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214366537 Which tests triggers this assertion? Could you summarize the explanation from [TS-4355](https://issues.apache.org/jira/browse/TS-4355) in the commit message? ---

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214311782 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214095730 @shinrich Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/600 TS-4355: Change assert condition for TS-3612 You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335/trafficserver ts-4355 Alterna