Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58294627
--- Diff: proxy/hdrs/test_mime.cc ---
@@ -0,0 +1,80 @@
+/** @file
+
+ A brief file description
+
+ @section license License
+
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58294561
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58237084
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58236316
--- Diff: proxy/hdrs/test_mime.cc ---
@@ -0,0 +1,80 @@
+/** @file
+
+ A brief file description
+
+ @section license License
+
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58233222
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58231677
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58230651
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58226891
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r58225733
--- Diff: proxy/hdrs/MIME.cc ---
@@ -3615,6 +3617,14 @@ MIMEFieldBlockImpl::strings_length()
return ret;
}
+bool
+MIMEFieldBloc
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-204436318
I've added contains() and tests for this.
@jpeach Can you review them?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203736906
Oh interesting. It looks like the pointers are ~500GB apart, so that
certainly confirms the problem you found! I wonder if that is specific to the
ASAN virtual add
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203732053
@jpeach
I added some codes for debug and got these output. The rare case is
happening.
(I built with --enable-debug and ASAN using clang on OSX.)
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203489537
``ptrdiff_t`` is the right type for pointer arithmetic.
That said, I don't really understand the problem here. If ``field`` is not
in the ``MIMEFieldBlockI
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/542#discussion_r57907840
--- Diff: proxy/hdrs/MIME.cc ---
@@ -473,7 +473,8 @@ mime_hdr_set_accelerator_slotnum(MIMEHdrImpl *mh,
int32_t slot_id, uint32_t slot
inline void
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/542#issuecomment-203478841
Nice catch! +1. I think we should mark this as a possibly back port to
6.1.2 as well.
Do you know if this bug is in 5.3.x as well? If so, it likely should g
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/542
TS-4313: Fix improper type conversion
https://issues.apache.org/jira/browse/TS-4313
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/
17 matches
Mail list logo
