Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206131655
@jpeach I didn't know we can use `TestBox.h` in Unit Tests:p I'll fix tests
to use it.
https://github.com/apache/trafficserver/blob/edf9ff13db4e63ee9b5003b
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206128440
@jpeach I agree with using many asserts is ugly. But if I understand
correctly, when we use `TestBox.h`, we need to write tests as Regression Tests.
Right?
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206113719
@masaori335 you can use ``TestBox.h`` for a simple regression test harness.
There's other examples of doing this in the tree. The test output is better and
you get
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206105027
Cool! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206096251
@maskit Comparator is added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203783017
Looks good except the comparator part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58005122
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section li
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58005044
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @sectio
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r58004342
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,207 @@
+/** @file
+
+ Priority Queue Implementation using Min Heap.
+
+ @section li
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203739388
@maskit Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996852
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996567
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section li
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996306
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57996067
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @sectio
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-203415277
There should be a test case for decreasing weights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57880884
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
+
+ @section li
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/537#discussion_r57860698
--- Diff: lib/ts/PriorityQueue.h ---
@@ -0,0 +1,191 @@
+/** @file
+
+ Priority Queue Implimentation using Min Heap.
--- End diff --
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-200852273
This looks clean to me, but I haven't not checked for correctness. +1 from
me.
---
If your project is set up for it, you can reply to this email and have your
repl
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/537
TS-4295: Add Priority Queue in lib/ts/
[TS-4295](https://issues.apache.org/jira/browse/TS-4295)
You can merge this pull request into a Git repository by running:
$ git pull https://gi
20 matches
Mail list logo
