[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-19 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/481#issuecomment-186442215 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-19 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-16 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/481#issuecomment-184719907 I addressed the comments above. At some point in the future I want to replace this with a page allocator for the freelists but that is going to be a bigger task

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-15 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/481#issuecomment-184527976 I just confirmed that this is correct, it will actually be hugepage aligned. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-15 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/481#issuecomment-184524565 All good :+1: just set alignment = 0 on declaration and let the complier deal with it if it's always assigned later. --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-15 Thread bgaff
Github user bgaff commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/481#discussion_r52969591 --- Diff: lib/ts/ink_queue.cc --- @@ -200,19 +200,20 @@ freelist_new(InkFreeList *f) if (TO_PTR(FREELIST_POINTER(item)) == NULL) { uin

[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...

2016-02-15 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/481 TS-4211: Make freelist_new cleaner so we can debug better. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver free