[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-05-03 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-216679391 I'll plan on working with @jacksontj at the summit next week to get the TSQA and openssl version issue figured out. --- If your project is set up for it, you ca

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-27 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-215194735 Making the test more robust sounds like the right approach to me. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-27 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-215163284 Yes, the current test is wrong. But it passed because the previous code was wrong. The correct behavior depends on what version of openssl the test is run agai

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-27 Thread JamesPeach
Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-215151224 So this patch skips the only test we have for this stuff? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-27 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-215141283 I added SkipTest for the TestMix test case. We need to add logic to only run that test if openssl 1.0.2 is present. Perhaps we can hash that out in the ATS sum

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-212078480 Well looking at the existing tests anyway told me that my initial solution was wrong. We are moving into the area where behavior changes between 1.0.2 and 1.0.1

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-18 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-211695320 Can you please update https://github.com/apache/trafficserver/blob/master/ci/tsqa/tests/test_https.py to test this case? --- If your project is set up for it, yo

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-18 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-211685166 Seems reasonable to me 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-18 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/578 TS-4180: Support for multiple intermediate cert chains Previous fix parsed the comma separated file names, but would only load the first file. You can merge this pull request into a Git rep