[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-02 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/435#issuecomment-179032182 This looks good to me. :+1: Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-02 Thread yishimur
Github user yishimur commented on the pull request: https://github.com/apache/trafficserver/pull/435#issuecomment-178980520 @bgaff Please take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-02 Thread bgaff
Github user bgaff commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/435#discussion_r51563391 --- Diff: lib/atscppapi/src/Transaction.cc --- @@ -186,6 +186,20 @@ Transaction::setErrorBody(const std::string &page) TSHttpTxnErrorBodySet(state_

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-01 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/435#issuecomment-178292993 Looks good to me. @bgaff Could you take a look this? If you're ok, I'll land this. --- If your project is set up for it, you can reply to this email and ha

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-01-21 Thread yishimur
GitHub user yishimur opened a pull request: https://github.com/apache/trafficserver/pull/435 TS-4144: Add TSHttpTxnSetHttpRetStatus wrapper in atsapp Add supports in Transaction class. 1. add new method to set http status code. 2. add setErrorBody to set mimetype. You can me