Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-173785344
The compatibility problem occurs when we fix the type of metrics. I'm
planning to look into that soon, but it is orthogonal to this branch (though
this branch is t
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-173770153
Did we resolve the issues around the .snap file compatibility issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-17376
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-173756818
@shukitchan any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49960578
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics.
+ *
+ * @section
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49960411
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
+ *
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49959828
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49959792
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics.
+ *
+ * @sect
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49822970
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
+ *
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49822945
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics.
+ *
+ * @section
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49809962
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49808951
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics.
+ *
+ * @sect
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171817699
Ok, let's defer that to a separate ticket. The ``stats.config.xml`` is not
documented so this isn't any worse.
---
If your project is set up for it, you can reply
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171777895
should we add something here in these 2 places ?
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/index.en.html
https://docs.tra
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171772919
There are some documentation in [header
comments](https://github.com/jpeach/trafficserver/blob/TS-4099/proxy/config/metrics.config.default),
but I'd be happy to ad
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171767764
awesome. will take some time to review it today/tomorrow.
Would be nice if you can take some time to write the doc to accompany this
feature. thanks.
---
17 matches
Mail list logo
