Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168899579
ha. my bad english
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168899277
Oh I see, that makes sense. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168898944
@jpeach
Before the change the lua number is always an integer (e.g. 1451970346).
Now after the change the lua number will contain the fraction of the secon
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168896100
I guess I still don't get it. This API already returned a Lua number, so
the only semantic change I can see is that there is no longer any potential
issue with tru
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168871196
@jpeach
Yes. the time is still in seconds. But instead of returning an integer all
the time, it is now a "lua_Number", which is like a "double".
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168836153
This still returns time in seconds, since the arithmetic is the same. If
you change the time units should you add a new API to preserve compatibility?
---
If your
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168799362
@jpeach , can you take a quick look on this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/394
TS-4096: ts.now() should return subsecond info for ts_lua plugin
@bgaff and @zwoop , pls review
You can merge this pull request into a Git repository by running:
$ git pull https://gi
