Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57849578
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive() con
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57056410
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (len
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57029193
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56920295
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (len
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-199522681
Overall it looks good. I had a couple comments in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56910134
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,175 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
-
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56909414
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive()
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56908946
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-187824312
I will take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53552779
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
DebugHt
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53549624
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
DebugHt
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53448759
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53446831
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
-sta
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53417506
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53414542
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
Deb
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r53414029
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
Deb
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-185757269
Also, this fixes a bug in the HPACK decoding process. Current decoding
process stops if there is a HTTP2 violation (not HPACK violation) but it should
not. As I co
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-185754698
@jpeach , I changed some function names as per your comments. But some are
not exactly the same as you suggested because I think the names should
correspond to the
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/460
TS-4092: Decouple HPACK from HTTP/2
I tried to decouple HPACK from HTTP2, and it partially succeeded. It's very
difficult to completely decouple HPACK unless we use MIMEField in it.
#
20 matches
Mail list logo
