Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-167193001
Yeah, that's a good idea (putting all SSL library weirdness in one file).
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-167155989
Oh that's a bit nasty, we should add a comment to that effect. I think it
would be best to consolidate the openssl includes in one header so we can
capture this ki
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-166989854
James, the problem is that if you do what you suggest, it likely will fail.
It will still find that OpenSSL include file (because it's likely to be on the
system),
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-166942353
+1 after fixing review comments. We should aim to not have to use
```OPENSSL_IS_BORINGSSL```.
---
If your project is set up for it, you can reply to this email an
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-166925947
Looks good to me as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/386#issuecomment-165671592
Looks good to me, ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/386
TS-4088: Add support for BoringSSL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver master
Alternatively you ca
