[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-214905902 It looks like @bcall merged it up as part of f17e7c6ddf8d771b3dc21b59360e982c55423c46 but mislabeled it for TS-4056. So it is definitely in there. --- If you

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-21 Thread oknet
Github user oknet commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-212809087 @shinrich I'm closed the PR, but github show me "but the oknet:patch-1 branch has unmerged commits". --- If your project is set up for it, you can reply to this em

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-21 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/373 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-212108558 Ok, I see, @bcall commited this change on 12/14/15, but was off by one in the bug number, So all the commits didn't necessarily line up nicely. The commit # was

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-212107082 Sorry for the long delay. It looks like the original code change in this PR got committed to master through one path or another. @oknet you can go ahead and cl

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-02-23 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-187818356 @shinrich is going to shepard this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2015-12-23 Thread oknet
Github user oknet commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-167039829 Thanks! you are right. I got a core file that show me the write_vio is NULL in gdb. Can you revert this pull request then create a new patch to set write_vio in Ht

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2015-12-23 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-166932419 The change is small enough to be reasonable defensive code. And it if got rid of your crash, that is great. However, a better solution may be to assign

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2015-12-12 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/373 TS-4055: InactivityCop callback SM with INACTIVE_TIMEOUT before NET_EVENT_OPEN for explain: on a heavy load system, HttpSM create a connection to OS. First, a TCP-SYN packet s