Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/361#issuecomment-162101407
Thanks Leif for reviewing. Please take a look at changes and approve.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/361#issuecomment-162083854
Yeah, so there's no leak here (sorry, my bad), but I feel these checks are
unnecessary. I'd rather change this to have a release assert above this, e.g.
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/361
TS-4050 - Trafficserver is crashing when buckets=0 is configured in
cache_promote plugin
Fix trafficserver crash when buckets=0 is configured in cache_promote
plugin and Set buckets default
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/361#issuecomment-161826127
Much better!
I'll have to check / read the code more thoroughly, but are you sure this
isn't now leaking the object when the freelist is empty?
Github user meeramn closed the pull request at:
https://github.com/apache/trafficserver/pull/360
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/360#issuecomment-161822868
Closing this. I will open new pull request with actual changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/360#issuecomment-161801444
Hmmm, I'll have to review this further, but there seems to be a lot other
changes here in this PR, unrelated to this actual fix. Why is that? Why is so
much code ch
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/360
TS-4050 - Trafficserver is crashing when buckets=0 is configured in
cache_promote plugin
Fix trafficserver crash when buckets=0 is configured in cache_promote
plugin and Set buckets default
