Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-199878590
ping on API review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-187818009
Talking at the github meeting. We should have a maximum size that will be
buffered in memory. This should go through API review. Please provide
documentation
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-168861430
Any other questions about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-164477764
Cool, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-164477595
That's correct since both use fetchsm if just works like a normal http 1.1
request, as that's what fetch sm is. I've verified this functionality.
---
If your proje
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-164477130
@bgaff - Thanks, I'd have to double check though that the change made
automatically handles a H2/SPDY upload. There's no Content-Length, nor even a
TE header in
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-164333421
@sudheerv / @jpeach this pull request has been updated w/ tests for the
chunked encoding case that @sudheerv was concerned about. Please let me know if
you have any
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-162415337
@sudheerv, I've asked @zizhong to help in addressing the transfer-encoding
chunked case, we should have an update soon.
---
If your project is set up for it, you c
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-162403177
@sudheerv , the chunked encoding case is one that I don't think any browser
actually does, have you ever seen a browser make a request w/ chunked encoding
if so I'l
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-160778560
+1 on the approach.
A specific comment on a quick scan of the code - it seems like the patch
only handles the case with *Content-Length* header, what abo
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-160427748
@jpeach sure thing. Does anyone else have comments regarding the approach
before we discuss the individual APIs?
---
If your project is set up for it, you can repl
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-159765613
I quickly scanned the diff. The API changes will still need to go through
API review on dev@. Documentation for the new APIs should be done as an API man
page in t
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-159744211
Glad to see this PR finally make its way out :) We've been running with the
base for this PR for quite a while. In addition to simplifying the code-- it
really
GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/351
TS-4042: Add feature to buffer request body before making downstream
requests
We need a way to examine the request body without making a downstream
request, this feature has many use cases inc
14 matches
Mail list logo
