[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-164002946 Updated with url_len removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163998438 @jrushf1239k I think this will land before #359, so you will have to rebase. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163997300 There was a lot of redundant or plainly wrong code in there. Like we treated round_robin as a boolean and as an enum. Also a little bit of added NULL ch

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163996272 Looks good to me now, +1. It's a little difficult to decipher the refactoring in ParentRecord::FindParent, I assume that's mostly optimizations? --- If your projec

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-08 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-162997233 This mostly looks good, except in +char * +ParentRecord::getHashPath(RequestData *rdata, size_t *path_len) +{ I think, but

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-08 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/369 TS-4030: Allow parent selection to ignore query string This allows you to drop the query string when doing the consistent hash in parent selection. Default behavior is the same. Add `qstrin