Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123753341
Sounds good to me just wanted to make sure they both get closed out!
---
If your project is set up for it, you can reply to this email and have your
repl
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123593668
Yeah, close TS-2152 as a dupe of TS-3780, since there's so much work done
on this PR already. In general, please file Jira's before work / pull requests
are done, s
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123589377
Hi @ericcarlschwartz , if you're cool with he proposed patch I'll land this
one and we can close out TS-2152 as a dupe.
---
If your project is set up for it, you c
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123413575
This looks like it's solving/a duplicate of
https://issues.apache.org/jira/browse/TS-2152
The code looks good to me too. If you're renaming commi
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123396100
Looks quite reasonable. I think we can improve the commit messages though.
[These](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
guidelines
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123178803
I worked with @zizhong on this pull request and it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/258
TS-3780: Custom log add incoming interface ip
Extending the custom log fields to support incoming server (interface) ip.
You can merge this pull request into a Git repository by running:
