[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-07-09 Thread fpesce
Github user fpesce closed the pull request at: https://github.com/apache/trafficserver/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-07-09 Thread fpesce
Github user fpesce commented on the pull request: https://github.com/apache/trafficserver/pull/218#issuecomment-120059157 Done @shinrich :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-07-09 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/218#issuecomment-119944358 Sorry I had a git log mishap pushing these changes. I missed the "This closes" comment and the changes showed up in the following for comments. {code}

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-07-07 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/218#issuecomment-119238728 My only comment is about the limits of the client_* fields. As they stand, they only accurately track HTTP/1.x over TCP/SSL, not requests over SPDY/H2. I know

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/218#issuecomment-116361206 Overall I think the log tags are useful in ways aggregate statistics are not and I support adding those tags. --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/218#discussion_r33428565 --- Diff: doc/reference/api/TSNetVConnSSLCachedHitSet.en.rst --- @@ -0,0 +1,32 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/218#discussion_r33428474 --- Diff: doc/admin/event-logging-formats.en.rst --- @@ -170,6 +170,24 @@ The following list describes Traffic Server custom logging fields.

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-11 Thread fpesce
GitHub user fpesce opened a pull request: https://github.com/apache/trafficserver/pull/218 TS-3683: Add log tag for SSL Session/Ticket HIT and TCP connection reused Additionally, a TSAPI function for those who used an external/plugin implementation for SSL Ticket/Session is provided