Github user oschaaf commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-110010001
@caguado my 2p is that renaming the specific gzip module for ats_pagespeed
is fine for now.
From the top of my head the gzip version from ats_pagespeed is nea
Github user caguado commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-110008880
How does it look? I'm quite new in writing autotools. Is it ok to rename
gzip.so to ats_pagespeed_gzip.so? Documentation would need an update too.
---
If your pr
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-108487426
That's fine, we have other stuff that only builds when it's dependencies
are available. I'm happy to advise if you want help doing this in autotools.
---
If your
Github user oschaaf commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-108486656
@jpeach Because the pagespeed libraries currently do not support all the
platforms that ATS does, so some work has to be done to exclude the plugin in
some platfo
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-108485861
Wait, why isn't page speed integrated into the automake build? We add these
macros to the build globally at configuration time.
---
If your project is set up for
Github user oschaaf commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-108296934
Great! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
GitHub user caguado opened a pull request:
https://github.com/apache/trafficserver/pull/210
TS-3607: Fix ats_pagespeed to use stdint.h macros
This commit adds _STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS to
fix the missing macros defined in stdint.h when building a C++ source
