[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-17 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-165605094 Fixed function declarations and removed url_len argument from the consistent hash lookup functions. --- If your project is set up for it, you can reply to th

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-17 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-165575394 James, I've made changes based upon your suggestions. Please review --- If your project is set up for it, you can reply to this email and have y

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-16 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-165326498 > Note that FindParent() used to take a ParentConfigParams. Since the lookup policy is now spread > over the ParentRecord and the the config_params structures,

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-16 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-165243856 I haven't had time to review again, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-16 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-165233077 Hey @jpeach, where do you feel this sits? @zwoop is branching 6.1.x soon and wondering if this can make it in or we should push it back to 6.2.x. thanks

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-09 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-163500832 Thanks @jrushf1239k. Now that we have a pretty clean commit on this branch, I think that it is OK to make any additional changes in new commits. I think th

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-09 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-163386805 Done, Thanks for the git help! Thanks -- John J. Rushford IPCDN Engineering 1400 Wewatta Street, Denver Colorado 80202 john_rushf..

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-08 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-163112743 We are almost there. To get the commits in the right order we can squash commit 3 into commit 1 and remove the accidental changes to ```lib/tsconfig/TsConfigSyntax

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-07 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-162602947 Hi James, I've squashed several commits and cleaned up the history, I'll be more descriptive in the future. Also, I found that I had left in some cod

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-06 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/359#issuecomment-162380212 Hi John. First, let's clean up the commit history on this branch. - please squash the "clang format" and "updated comments" commits into their respective p

[GitHub] trafficserver pull request: TS-3418: Second hash ring for consiste...

2015-12-02 Thread jrushf1239k
GitHub user jrushf1239k opened a pull request: https://github.com/apache/trafficserver/pull/359 TS-3418: Second hash ring for consistently hashed parent selection This pull request is to add an optional secondary hash ring to parent selection and is based upon feedback from James Pe