[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-28 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-23 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166948715 Ah. Yep that seems fair enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-23 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166929171 Hmmm. I did use it at one point during development of this patch but it appears that code was removed. I'd prefer to leave it in for future use, although

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166795111 I just meant that I didn't see it used in this patch. Did I look in the right place? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166794993 It lets the C++ API lock a mutex that is contained in a continuation in a scoped fashion. The already existing mutex locking mechanisms handle mutexes via

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166789440 What is ```ScopedContinuationLock``` for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/397 TS-3235: fix crash problem caused by sync problem in PluginVC. This is an updated version of PR 164 that has been tested in production. It attempts to fix the related issue in the C++