Github user jacksontj closed the pull request at:
https://github.com/apache/trafficserver/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71758627
This was merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71566714
@jpeach fixed the typo (and squashed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71565910
TSQA, although used by these tests, aren't only useful in this setting. For
example, we use them already for testing our internal plugins and some internal
build
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71565565
Hmmm that's a hurdle. Why does it need its own git repo? Or are you
suggesting you will incubate his as a new apache project?
Confused.
>
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71565101
The dep can and is easily installed using pip into a virtual env (the
makefile does all the work for you). Basically the tsqa library is treated as
any other pyt
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71563685
Hmmm so I can't run tsqa without going to another repository? That doesn't
make any sense. Having dependencies libraries that are easily installed via eg
pip or yum
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71562735
@jpeach and I chatted on IRC. I think the main source of confusion is that
the tests are *not* going to live outside the source tree-- just the tsqa
library.
-
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71561413
How do you deal with versioning? ie. when a test requires a specific commit
to pass?
---
If your project is set up for it, you can reply to this email and have you
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71556279
I still don't understand the want/need to include this in the base source
tree... The tests basically require a bunch of python deps (requests, flask,
tsqa, etc.
Github user bretep commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-7124
@zwoop I can get behind that. I'd much rather have it merged myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71299904
Not sure why you would prefer not to just merge it in, but I can with 99%
certainty say that we would not include it as a git submodule. We would
consider it as a gi
Github user bretep commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71299489
@jacksontj how about adding it as a git submodule?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71293965
Yes.
> On Jan 23, 2015, at 5:29 PM, Thomas Jackson
wrote:
>
> Also, do we need the Apache file headers on all test cases as well?
(@zwoo
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71289896
Also, do we need the Apache file headers on all test cases as well?
(@zwoop would probably be the one to answer)
---
If your project is set up for it, you can
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71289722
A point @bgaff brought up was that tsqa (the harness/framework) lives
outside this source tree. This is intentional as the *tests* are tied to the
trafficserver
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-71288426
@bgaff I squashed all of the commits into one. I've also changed it from
traffic_cop to traffic_server while we wait for @jpeach 's commit to land.
---
If your
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/163#issuecomment-70197110
And before we merge this I can squash if we want a cleaner commit log :)
---
If your project is set up for it, you can reply to this email and have your
reply ap
18 matches
Mail list logo
