Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
I agree that this is the preferred pattern given this situation, the
message is very clear: this object is no longer in use and then when it's
assigned again at the start it's clear it's in use again.
On Mon, Jul 6, 2015 at 9:51 PM, SolidWallOfCode wrote:
> Github user SolidWallOfCode commented
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33935287
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if (!HostFilePairs
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33837875
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if (!HostFilePairs.empty
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33836997
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if (!HostFilePairs.empty())
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33831438
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2771,11 +2586,14 @@ ParseHostLine(char *l)
int n_elts = elts.Initialize(l, SHARE_TOKS);
// Ele
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33824514
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2771,11 +2586,14 @@ ParseHostLine(char *l)
int n_elts = elts.Initialize(l, SHARE_TOKS);
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820816
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2565,18 +2568,9 @@ int HostDBFileUpdateActive = 0;
// Contents of the host file. We keep this aro
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820620
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -659,6 +660,21 @@ db_mark_for(IpAddr const &ip)
HostDBInfo *
probe(ProxyMutex *mutex, HostDBM
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33820528
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define HOSTDB_DECREMENT_THREAD_DY
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33817237
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if (!HostFilePairs.empty
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33813578
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2833,15 +2650,8 @@ ParseHostFile(char const *path)
}
}
- if (!HostFilePairs
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33811976
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -659,6 +660,20 @@ db_mark_for(IpAddr const &ip)
HostDBInfo *
probe(ProxyMutex *mutex, HostDBMD5 con
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33811033
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -659,6 +660,20 @@ db_mark_for(IpAddr const &ip)
HostDBInfo *
probe(ProxyMutex *mutex, HostDBM
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33810813
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define HOSTDB_DECREMENT_THREAD_DY
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/240#discussion_r33810635
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
#define HOSTDB_DECREMENT_THREAD_DY
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/240#issuecomment-117899443
I reviewed this and iterated with @jacksontj and so obviously I give this a
+1, @SolidWallOfCode can you please take a look at this latest version?
---
If your pro
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/240#issuecomment-117899355
@SolidWallOfCode This should fix your hosts file feature (TS-3725)
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/240
Maintain and use a mapping of hostname -> IP to implement host file support
This allows the background thread to populate a map of overrides, which we
simply inject in the lookup method-- i
19 matches
Mail list logo
