[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/162#issuecomment-69966381 As it turns, out the records.config processing already checks that tr-in is set if you are trying to set tr-pass. I filled TS-3293 to track the issue of

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/162#issuecomment-69951456 hmm, can it not be used as a bit-map for other kinds of transparency? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread stipa
Github user stipa commented on the pull request: https://github.com/apache/trafficserver/pull/162#issuecomment-69949310 shinrich: added check you've mentioned sudheerv: right, but that one is about inbound transparency: https://github.com/apache/trafficserver/blob/master/i

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/162#issuecomment-69947824 Isn't there a "NetVConnection::is_transparent" already in the netvc? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/162#issuecomment-69942861 Looks good to me. Originally concerned that the transparent_passthrough state was being needlessly duplicated, but the HttpSM is not here yet at this point. And

Re: [GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread Susan Hinrichs
Associated with TS-3292. I'll review and merge later this morning. On 1/14/2015 3:04 AM, stipa wrote: GitHub user stipa opened a pull request: https://github.com/apache/trafficserver/pull/162 Allow transparent pass through for SSL port If the parsing of ClientHello fails and f

[GitHub] trafficserver pull request: Allow transparent pass through for SSL...

2015-01-14 Thread stipa
GitHub user stipa opened a pull request: https://github.com/apache/trafficserver/pull/162 Allow transparent pass through for SSL port If the parsing of ClientHello fails and first byte does not indicate SSL packet, start a blind tunnel if tr-pass is set. This feature all