[GitHub] trafficserver pull request: Added SSL related fields to access.log

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2015-07-13 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-121054986 @fpesce got the ssl_session_reuse in TS-3683 (cqssl rather than cssr for the log field). It also includes session reuse via tickets. Being able to recor

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2015-07-13 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/122#discussion_r34509593 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -120,6 +120,28 @@ class SSLNetVConnection:public UnixNetVConnection sslClientRenegotiationAb

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2015-06-17 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-112870570 There is a related Jira for this: Desire support for client TLS cipher in custom log format https://issues.apache.org/jira/browse/TS-3648 --- If your pr

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2015-01-29 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-72101354 FWIW for this specific case, you can use the ``sslheaders`` plugin as a workaround. Put the values you want into HTTP headers, then log those. In fact, maybe using

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-23 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-60306213 While I agree with James' distaste, it will be rare for the NetVC to be around to provide this information. My recommendation at this point is to s

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-23 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-60304789 I don't like that this adds extra fields to HttpSM, can we avoid that by accessing the netvc? or is it too late by the time we want to log? --- If your project is

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-23 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-60270408 We should probably track this as a jira item... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-15 Thread bellofreedom
Github user bellofreedom commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/122#discussion_r18934621 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -120,6 +120,28 @@ class SSLNetVConnection:public UnixNetVConnection sslClientRenegotiati

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-15 Thread acaciocenteno
Github user acaciocenteno commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-59286543 Did a test using spdycat and ATS did no log the SSL infos. Will dig into the code tomorrow to learn why. --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-15 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-59230086 How will SPDY-enabled connections be logged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-09-25 Thread acaciocenteno
GitHub user acaciocenteno opened a pull request: https://github.com/apache/trafficserver/pull/122 Added SSL related fields to access.log Added three fields to access log: - SSL version, for instance 'TLSv1/SSLv3'. - SSL cipher suite, for instance 'ECDHE-RSA-AES128-GCM-SHA256'