Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-134748516
Ok, I think the consensus is that we don't change anything. Sorry Meera,
but thanks for all the work. And I whole heartedly agree that we should
eliminate the std::
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-134748136
Looking at isNonstandardMethodAllowed I am OK with just using that.
However it should be modified without using std::string. Also, there should be
documentati
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-134705705
I am for putting these methods into ipallow.config. You are able to expand
on the set of common methods as defined in section 9 of RFC2616. Also, we
already s
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-131523307
@zwoop - Yes, it should already be possible to do this using the existing
code.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130491241
@ushachar Ah, so the argument is to not add special handling for this, but
still allow them to be used in ip_allow.config? If so, that seems fine.
---
If your proj
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130400491
I'm going to side with Uri on this one as well. Adding those to the core
HTTP method list seems wrong to me. As I understand, the real goal here is just
f
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130198618
I'm not advocating rejecting all non-standard methods out of hand -- I'm
just saying they don't belong in our recognized method list.
As a general approach, I
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130127185
I should say, if there was a reasonable way to add functionality to
ip_allow.config via plugins, that would make a lot of sense. But, I don't think
there is.
---
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130126864
That seems draconian to rule out these methods only because they are not in
the main HTTP RFCs. Since ATS is a general forward (and transparent) proxy, it
seems rea
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130113092
I don't really see why ```ip_filter``` should not be able to deal with
webdav methods. It seems reasonable to me that you should be able to filter any
layered meth
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130105002
I'm in agreement with @ushachar and @sudheerv on this one, I do not
believe webdav methods should land in the core.
---
If your project is set up for it, you can
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130071743
@meeramn : I agree with the comments that this change seems like something
that can (and should?) be done in a plugin rather than in the core. It should
be fairl
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130058487
ushachar: I made changes to support webdav methods in ip_allow.config. I
haven't implemented these methods - it just look for list of list of methods to
allow or
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-128261744
I'm not too sure about this -- It's one thing to allow/block unknown
methods that parse properly (TS-1232/TS-1407), but adding non-HTTP methods to
the HTTP metho
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/270
Add support for webdav methods in ip_allow
Add support for webdav methods in ip_allow - COPY, MOVE, LOCK, UNLOCK,
PROPFIND, PROPPATCH, MKCOL, REPORT, CHECKOUT
You can merge this pull request
16 matches
Mail list logo
