Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-214042675
Closing in favor of #594.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-199870599
@biilmann Can you email something to the dev@ mailing list with the API
proposal, for a review? See the link above for the process.
---
If your project is set up f
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-197684472
@biilmann The next thing we need here is an [API
review](https://cwiki.apache.org/confluence/display/TS/API+Review+Process)
posted to the dev@ list. It would also
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-187818521
To @jpeach to shepherd.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-171990184
Yes, I agree that having a matching TSSslContextDestroy is a good idea even
if it is just a wrapper for the openssl call at this point.
I also like the i
Github user biilmann commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-171775715
@shinrich I'll send out an API review notice. Before that, what's your
thoughts on adding a `TSSslContextDestroy` method to clarify that it's up to
the plugin to
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-170925335
I think this looks good, and I'd be willing to do the merge, but I think
you still need to send around an API review notice to the dev mailing list as
jpeach sug
Github user biilmann commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-169107617
> I assume that the bulk of the diff'ed lines in SSLUtils are due to just
moving functions ahead of use and the functions themselves are unchanged (e.g.,
asn1_st
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-169014530
Looks good to me as well. Seems like a good and necessary change.
I assume that the bulk of the diff'ed lines in SSLUtils are due to just
moving functio
Github user biilmann commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168927960
Changed the type signature to `TSSslContextCreate(void)` now.
It generally makes sense that a plugin that needs this method will want to
handle the call
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168898043
This looks pretty reasonable to me. @shinrich, what do you think?
In ``ts/ts.h``, ``TSSslContextCreate()`` needs to be
``TSSslContextCreate(void)``.
Github user biilmann commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168449041
I've done a bit of cleanup to get anything not related to storing the ssl
context moved from `ssl_store_ssl_context` and into `SSLInitServerContext`.
---
If you
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168268438
> Ideally I would refactor that method to separate context initialization
and configuration from
> inserting the context into the SSLCertLookup
Yeh th
GitHub user biilmann opened a pull request:
https://github.com/apache/trafficserver/pull/402
Add TSSslContextCreate method
TSSslContextCreate returns a new SSL Context that's configured according to
the settings in records.config
This is useful if an extension wants to u
15 matches
Mail list logo
