Github user bgaff closed the pull request at:
https://github.com/apache/trafficserver/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120851447
All, I've incorporated @SolidWallOfCode 's feedback which renames the
method to iterate / iterateEvent, additionally i've modified the code to
reschedule if it's un
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34431849
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1037,6 +1037,33 @@ HostDBProcessor::getbyname_imm(Continuation *cont,
process_hostdb_info_pfn proce
retu
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34431846
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1801,6 +1828,39 @@ HostDBContinuation::do_put_response(ClusterMachine
*m, HostDBInfo *r, Continuati
clus
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34371196
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1801,6 +1828,39 @@ HostDBContinuation::do_put_response(ClusterMachine
*m, HostDBInfo *r, Continuati
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/245#discussion_r34371142
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -1037,6 +1037,33 @@ HostDBProcessor::getbyname_imm(Continuation *cont,
process_hostdb_info_pfn proce
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120191769
@jpeach from our conversations on IRC it sounds like you aren't opposed to
adding this, but rather want to start making this more general. If we could
make a ti
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120191816
@SolidWallOfCode How does this PR look to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120151397
Because generating raw HTML in core code is unmaintainable. The right
approach is to extract the data and publish it in the appropriate format for
the consumer (e.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120147643
Why do we want to kill the httpui? We use it all the time for stats
collection
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120083151
Absolutely agree, lets not put more stuff into httpui, we should aim to
eliminate it for 7.0.0. Move things over to the management port and traffic_ctl
please.
--
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120039117
I'm strongly in favor of introspecting HostDB, but I don't like extending
HTTPUI. The right way to do this IMHO is to add management APIs so you can
expose it thro
GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/245
Add ListAll for HostDB httpui endpoint
We would like a way to enumerate all records in hostdb (this doesn't
include the hostsfile map, although adding that would be a trivial change). I
really
13 matches
Mail list logo
