Re: [GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread Alan Carroll
Another PR probably. This was really in the nature of an API review, I didn't actually write any of the code yet. On Tuesday, March 22, 2016 11:01 AM, zwoop wrote: Github user zwoop commented on the pull request:     https://github.com/apache/trafficserver/pull/272#issuecomment-199880

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-199880458 @SolidWallOfCode You going to land this in this incarnation? Or another PR? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-02-23 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-187800809 @SolidWallOfCode said he would work on it this quarter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2015-12-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-165182928 See https://issues.apache.org/jira/browse/TS-2375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2015-10-13 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-147929606 *TSHttpTxnApplyLogFormat* - I think the name could be clearer, maybe TSHttpTxnFormatLogTags() or TSHttpFormatTags(). - It seems reasonable to format to

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2015-08-07 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-128797783 I added the new function `TSIOBufferReaderIsAvailAtLeast` because this has proved handy in the core and (since it's an existing method) this will be easy

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2015-08-07 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/272 API: Proposal for additional IO buffer and body template API. This is not intended to be merge immediately because it describes API that has not yet been written. Comments should be a